Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish migration to edge-based for endpoints in KubeProxy #44318

Merged
merged 2 commits into from
Apr 14, 2017
Merged

Finish migration to edge-based for endpoints in KubeProxy #44318

merged 2 commits into from
Apr 14, 2017

Conversation

wojtek-t
Copy link
Member

Ref #43702

@wojtek-t wojtek-t added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 11, 2017
@wojtek-t wojtek-t self-assigned this Apr 11, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@wojtek-t wojtek-t mentioned this pull request Apr 11, 2017
Merged
@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2017
@wojtek-t wojtek-t removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 12, 2017
@wojtek-t wojtek-t assigned thockin and unassigned wojtek-t Apr 12, 2017
@wojtek-t
Copy link
Member Author

@thockin - this is second part of the PR that you lgtm-ed yesterday. Basically:

  • the first commit is almost copy-paste from the commit from previous PR (userspace vs winuserspace)
  • the second commit is cleaning handlers that are no longer used due to changes
    It should be straightforward to review.

@wojtek-t
Copy link
Member Author

@thockin @bowei - if one of you could take a look, it would be great.

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2017
@wojtek-t
Copy link
Member Author

Thanks a lot Tim!

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 14, 2017 •
edited

@wojtek-t: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins Bazel Build af71083 link @k8s-bot bazel test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44414, 44318)

@k8s-github-robot k8s-github-robot merged commit d65b0b1 into kubernetes:master Apr 14, 2017
@wojtek-t wojtek-t deleted the edge_based_proxy_2 branch May 23, 2017 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bowei bowei

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wojtek-t @k8s-github-robot @k8s-reviewable @k8s-ci-robot @bowei @thockin